linux-kernel - Re: [PATCH] random: pull add_hwgenerator_randomness() declaration into random.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YglfCDoerzbaviDP@owl.dominikbrodowski.net>
Date:   Sun, 13 Feb 2022 20:42:00 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-kernel@...r.kernel.org, herbert@...dor.apana.org.au,
        linux-crypto@...r.kernel.org, Matt Mackall <mpm@...enic.com>,
        Kalle Valo <kvalo@...nel.org>, ath9k-devel@....qualcomm.com,
        Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH] random: pull add_hwgenerator_randomness() declaration
 into random.h

Am Sun, Feb 13, 2022 at 04:25:22PM +0100 schrieb Jason A. Donenfeld:
> add_hwgenerator_randomness() is a function implemented and documented
> inside of random.c. It is the way that hardware RNGs push data into it.
> Therefore, it should be declared in random.h. Otherwise sparse complains
> with:
> 
> random.c:1137:6: warning: symbol 'add_hwgenerator_randomness' was not declared. Should it be static?
> 
> The alternative would be to include hw_random.h into random.c, but that
> wouldn't really be good for anything except slowing down compile time.

Reviewed-by: Dominik Brodowski <linux@...inikbrodowski.net>