linux-kernel - [toke:xdp-queueing-02 5/11] kernel/bpf/pifomap.c:197:6: warning: no previous prototype for 'pifo_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202202140539.izxJMSE3-lkp@intel.com>
Date:   Mon, 14 Feb 2022 06:02:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [toke:xdp-queueing-02 5/11] kernel/bpf/pifomap.c:197:6: warning: no
 previous prototype for 'pifo_set_bit'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/toke/linux.git xdp-queueing-02
head:   26dde94b299bc277f7a99a99ba64b4363964e833
commit: 34cc5abfbae0dfcb6967c54cb80f7595bc9c5c37 [5/11] Add a PIFO map type for queueing packets
config: i386-randconfig-a003 (https://download.01.org/0day-ci/archive/20220214/202202140539.izxJMSE3-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/toke/linux.git/commit/?id=34cc5abfbae0dfcb6967c54cb80f7595bc9c5c37
        git remote add toke https://git.kernel.org/pub/scm/linux/kernel/git/toke/linux.git
        git fetch --no-tags toke xdp-queueing-02
        git checkout 34cc5abfbae0dfcb6967c54cb80f7595bc9c5c37
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> kernel/bpf/pifomap.c:197:6: warning: no previous prototype for 'pifo_set_bit' [-Wmissing-prototypes]
     197 | void pifo_set_bit(struct bpf_pifo_queue *queue, u32 rank)
         |      ^~~~~~~~~~~~
>> kernel/bpf/pifomap.c:208:6: warning: no previous prototype for 'pifo_clear_bit' [-Wmissing-prototypes]
     208 | void pifo_clear_bit(struct bpf_pifo_queue *queue, u32 rank)
         |      ^~~~~~~~~~~~~~


vim +/pifo_set_bit +197 kernel/bpf/pifomap.c

   196	
 > 197	void pifo_set_bit(struct bpf_pifo_queue *queue, u32 rank)
   198	{
   199		u32 i;
   200	
   201		for (i = queue->levels; i > 0; i--) {
   202			unsigned long *bitmap = queue->lvl_bitmap[i-1];
   203			set_bit(rank, bitmap);
   204			rank /= BITS_PER_TYPE(long);
   205		}
   206	}
   207	
 > 208	void pifo_clear_bit(struct bpf_pifo_queue *queue, u32 rank)
   209	{
   210		u32 i;
   211	
   212		for (i = queue->levels; i > 0; i--) {
   213			unsigned long *bitmap = queue->lvl_bitmap[i-1];
   214			clear_bit(rank, bitmap);
   215			rank /= BITS_PER_TYPE(long);
   216	
   217			// another bit is set in this word, don't clear bit in higher
   218			// level
   219			if (*(bitmap + rank))
   220				break;
   221		}
   222	}
   223	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org