linux-kernel - Re: [PATCH v3 1/3] dt-bindings: pinctrl: mt8186: add pinctrl file and binding document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab823da2bff2dddcbf563083c787631c9ef842b7.camel@mediatek.com>
Date:   Mon, 14 Feb 2022 11:03:58 +0800
From:   Guodong Liu <guodong.liu@...iatek.com>
To:     Rob Herring <robh@...nel.org>
CC:     Linus Walleij <linus.walleij@...aro.org>,
        Sean Wang <sean.wang@...iatek.com>,
        <linux-mediatek@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <linux-gpio@...r.kernel.org>, Sean Wang <sean.wang@...nel.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: mt8186: add pinctrl file
 and binding document

-----Original Message-----
From: Rob Herring <robh@...nel.org>
To: Guodong Liu <guodong.liu@...iatek.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, Sean Wang <
sean.wang@...iatek.com>, linux-mediatek@...ts.infradead.org, Rob
Herring <robh+dt@...nel.org>, linux-arm-kernel@...ts.infradead.org, 
linux-kernel@...r.kernel.org, 
Project_Global_Chrome_Upstream_Group@...iatek.com, Matthias Brugger <
matthias.bgg@...il.com>, linux-gpio@...r.kernel.org, Sean Wang <
sean.wang@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: mt8186: add pinctrl
file and binding document
Date: Thu, 10 Feb 2022 08:47:52 -0600

On Thu, 10 Feb 2022 14:21:20 +0800, Guodong Liu wrote:
> 1. This patch adds pinctrl file for mt8186.
> 2. This patch adds mt8186 compatible node in binding document.
> 
> Signed-off-by: Guodong Liu <guodong.liu@...iatek.com>
> ---
>  .../bindings/pinctrl/pinctrl-mt8186.yaml      |  313 +++++
>  include/dt-bindings/pinctrl/mt8186-pinfunc.h  | 1174
> +++++++++++++++++
>  2 files changed, 1487 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
>  create mode 100644 include/dt-bindings/pinctrl/mt8186-pinfunc.h
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml:
properties:reg-names: {'description': 'Gpio base register names.\n',
'items': [{'const': 'iocfg0'}, {'const': 'iocfg_bm'}, {'const':
'iocfg_bl'}, {'const': 'iocfg_br'}, {'const': 'iocfg_lm'}, {'const':
'iocfg_rb'}, {'const': 'iocfg_tl'}, {'const': 'eint'}], 'maxItems': 8}
should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml:
ignoring, error in schema: properties: reg-names
Documentation/devicetree/bindings/pinctrl/pinctrl-
mt8186.example.dt.yaml:0:0: /example-0/pinctrl@...05000: failed to
match any schema with compatible: ['mediatek,mt8186-pinctrl']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1590838

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

Hi Rob

Thank you fou your useful information, and we will update it for next
version.

Thanks
Guodong