linux-kernel - Re: [PATCH v4 08/24] EDAC/amd64: Define function to check DRAM limit address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgopjwgItEHPfFtF@zn.tnic>
Date:   Mon, 14 Feb 2022 11:06:07 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Yazen Ghannam <yazen.ghannam@....com>
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        mchehab@...nel.org, tony.luck@...el.com, james.morse@....com,
        rric@...nel.org, Smita.KoralahalliChannabasappa@....com
Subject: Re: [PATCH v4 08/24] EDAC/amd64: Define function to check DRAM limit
 address

On Thu, Jan 27, 2022 at 08:40:59PM +0000, Yazen Ghannam wrote:
> Move the DRAM limit check into a separate helper function.

You're still writing the "what" in commit messages - pls make a note to
write about "why" you're doing a change instead.

Because I don't see why you're doing this. Because
umc_normaddr_to_sysaddr() is supposed to call helper functions only?

Now if you had the "why" I wouldn't be wondering...

:)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette