linux-kernel - Re: [PATCH v2] nvmem: meson-mx-efuse: replace unnecessary devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Feb 2022 11:03:24 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     xkernel.wang@...mail.com, martin.blumenstingl@...glemail.com,
        narmstrong@...libre.com, khilman@...libre.com
Cc:     jbrunet@...libre.com, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nvmem: meson-mx-efuse: replace unnecessary
 devm_kstrdup()



On 17/01/2022 02:56, xkernel.wang@...mail.com wrote:
> From: Xiaoke Wang <xkernel.wang@...mail.com>
> 
> Replace unnecessary devm_kstrdup() so to avoid redundant memory allocation.
> 
> Suggested-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Signed-off-by: Xiaoke Wang <xkernel.wang@...mail.com>

Applied thanks,

--srini
> ---
> Changelogs:
> Simplify the patch to replace unnecessary devm_kstrdup().
>   drivers/nvmem/meson-mx-efuse.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/nvmem/meson-mx-efuse.c b/drivers/nvmem/meson-mx-efuse.c
> index 07c9f38..13eb143 100644
> --- a/drivers/nvmem/meson-mx-efuse.c
> +++ b/drivers/nvmem/meson-mx-efuse.c
> @@ -209,8 +209,7 @@ static int meson_mx_efuse_probe(struct platform_device *pdev)
>   	if (IS_ERR(efuse->base))
>   		return PTR_ERR(efuse->base);
>   
> -	efuse->config.name = devm_kstrdup(&pdev->dev, drvdata->name,
> -					  GFP_KERNEL);
> +	efuse->config.name = drvdata->name;
>   	efuse->config.owner = THIS_MODULE;
>   	efuse->config.dev = &pdev->dev;
>   	efuse->config.priv = efuse;