linux-kernel - Re: [PATCH v3] selftests/ftrace: Do not trace do_softirq because of PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ygo6pqWmkTWJNNcR@linutronix.de>
Date:   Mon, 14 Feb 2022 12:19:02 +0100
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, Shuah Khan <shuah@...nel.org>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rt-users@...r.kernel.org, joseph.salisbury@...onical.com,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3] selftests/ftrace: Do not trace do_softirq because of
 PREEMPT_RT

On 2022-02-14 09:36:57 [+0100], Krzysztof Kozlowski wrote:
> The PREEMPT_RT patchset does not use do_softirq() function thus trying
> to filter for do_softirq fails for such kernel:
> 
>   echo do_softirq
>   ftracetest: 81: echo: echo: I/O error
> 
> Choose some other visible function for the test.  The function does not
> have to be actually executed during the test, because it is only testing
> filter API interface.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Acked-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

> Notes:
> I understand that the failure does not exist on mainline kernel (only
> with PREEMPT_RT patchset) but the change does not harm it.

Yes, and now it does not sound (to me) like duct tape. Thank you.

> If it is not suitable alone, please consider it for RT patchset.

We trying to get it merged so…

Sebastian