linux-kernel - Re: [PATCH 06/15] dt-bindings: pwm: rockchip: include generic pwm schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Feb 2022 11:58:49 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Lee Jones <lee.jones@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Anson Huang <anson.huang@....com>,
        Vijayakannan Ayyathurai <vijayakannan.ayyathurai@...el.com>,
        Rahul Tanwar <rtanwar@...linear.com>,
        Jeff LaBundy <jeff@...undy.com>,
        Yash Shah <yash.shah@...ive.com>,
        Sagar Kadam <sagar.kadam@...ive.com>,
        Vignesh R <vigneshr@...com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-riscv@...ts.infradead.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Subject: Re: [PATCH 06/15] dt-bindings: pwm: rockchip: include generic pwm schema

Am Montag, 14. Februar 2022, 09:15:56 CET schrieb Krzysztof Kozlowski:
> Include generic pwm.yaml schema, which enforces PWM node naming and
> brings pwm-cells requirement.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> ---
>  .../devicetree/bindings/pwm/pwm-rockchip.yaml | 74 ++++++++++---------
>  1 file changed, 38 insertions(+), 36 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
> index 81a54a4e8e3e..a336ff9364a9 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
> @@ -51,42 +51,44 @@ properties:
>  required:
>    - compatible
>    - reg
> -  - "#pwm-cells"
> -
> -if:
> -  properties:
> -    compatible:
> -      contains:
> -        enum:
> -          - rockchip,rk3328-pwm
> -          - rockchip,rv1108-pwm
> -
> -then:
> -  properties:
> -    clocks:
> -      items:
> -        - description: Used to derive the functional clock for the device.
> -        - description: Used as the APB bus clock.
> -
> -    clock-names:
> -      items:
> -        - const: pwm
> -        - const: pclk
> -
> -  required:
> -    - clocks
> -    - clock-names
> -
> -else:
> -  properties:
> -    clocks:
> -      maxItems: 1
> -      description:
> -        Used both to derive the functional clock
> -        for the device and as the bus clock.
> -
> -  required:
> -    - clocks
> +
> +allOf:
> +  - $ref: pwm.yaml#
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - rockchip,rk3328-pwm
> +              - rockchip,rv1108-pwm
> +
> +    then:
> +      properties:
> +        clocks:
> +          items:
> +            - description: Used to derive the functional clock for the device.
> +            - description: Used as the APB bus clock.
> +
> +        clock-names:
> +          items:
> +            - const: pwm
> +            - const: pclk
> +
> +      required:
> +        - clocks
> +        - clock-names
> +
> +    else:
> +      properties:
> +        clocks:
> +          maxItems: 1
> +          description:
> +            Used both to derive the functional clock
> +            for the device and as the bus clock.
> +
> +      required:
> +        - clocks
>  
>  additionalProperties: false
>  
>