linux-kernel - Re: [PATCH 2/2] perf jevents: Add support for HiSilicon CPA PMU aliasing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1da1252e-59d0-77d1-0419-242528739392@huawei.com>
Date:   Mon, 14 Feb 2022 12:04:25 +0000
From:   John Garry <john.garry@...wei.com>
To:     Qi Liu <liuqi115@...wei.com>, "will@...nel.org" <will@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        Zhangshaokun <zhangshaokun@...ilicon.com>
Subject: Re: [PATCH 2/2] perf jevents: Add support for HiSilicon CPA PMU
 aliasing

On 14/02/2022 11:42, Qi Liu wrote:
> Add support for HiSilicon CPA PMU aliasing.
> 
> The kernel driver is in drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c
> 
> Signed-off-by: Qi Liu<liuqi115@...wei.com>

You realy should cc the perf tool list and maintainers there also.

Reviewed-by: John Garry <john.garry@...wei.com>

> +	},
> +	{
> +		"MetricExpr": "(p0_wr_dat * 64 + p0_rd_dat_64b * 64 + p0_rd_dat_32b * 32) / cpa_cycles",
> +		"BriefDescription": "Average bandwidth of CPA Port 0",
> +		"MetricGroup": "CPA",

nit: maybe this should have a more distrinct name

> +		"MetricName": "p0_avg_bw",
> +		"Compat": "0x00000030",

JFYI, I have a rewrite of the perf tool system pmu metric support that 
will not require us to add the compat here.

> +		"Unit": "hisi_sicl,cpa"

Thanks,
John