linux-kernel - Re: [PATCH] apparmor: fix aa_label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f42b0010-3a7b-e781-5b7e-ac975c36c102@canonical.com>
Date:   Sun, 13 Feb 2022 19:40:18 -0800
From:   John Johansen <john.johansen@...onical.com>
To:     trix@...hat.com, jmorris@...ei.org, serge@...lyn.com,
        nathan@...nel.org, ndesaulniers@...gle.com
Cc:     apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] apparmor: fix aa_label_asxprint return check

On 2/13/22 13:32, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Clang static analysis reports this issue
> label.c:1802:3: warning: 2nd function call argument
>   is an uninitialized value
>   pr_info("%s", str);
>   ^~~~~~~~~~~~~~~~~~
> 
> str is set from a successful call to aa_label_asxprint(&str, ...)
> On failure a negative value is returned, not a -1.  So change
> the check.
> 
> Fixes: f1bd904175e8 ("apparmor: add the base fns() for domain labels")
> Signed-off-by: Tom Rix <trix@...hat.com>

Acked-by: John Johansen <john.johansen@...onical.com>

thanks I have pulled this into my tree

> ---
>  security/apparmor/label.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/security/apparmor/label.c b/security/apparmor/label.c
> index 9eb9a9237926..a658b67c784c 100644
> --- a/security/apparmor/label.c
> +++ b/security/apparmor/label.c
> @@ -1744,7 +1744,7 @@ void aa_label_xaudit(struct audit_buffer *ab, struct aa_ns *ns,
>  	if (!use_label_hname(ns, label, flags) ||
>  	    display_mode(ns, label, flags)) {
>  		len  = aa_label_asxprint(&name, ns, label, flags, gfp);
> -		if (len == -1) {
> +		if (len < 0) {
>  			AA_DEBUG("label print error");
>  			return;
>  		}
> @@ -1772,7 +1772,7 @@ void aa_label_seq_xprint(struct seq_file *f, struct aa_ns *ns,
>  		int len;
>  
>  		len = aa_label_asxprint(&str, ns, label, flags, gfp);
> -		if (len == -1) {
> +		if (len < 0) {
>  			AA_DEBUG("label print error");
>  			return;
>  		}
> @@ -1795,7 +1795,7 @@ void aa_label_xprintk(struct aa_ns *ns, struct aa_label *label, int flags,
>  		int len;
>  
>  		len = aa_label_asxprint(&str, ns, label, flags, gfp);
> -		if (len == -1) {
> +		if (len < 0) {
>  			AA_DEBUG("label print error");
>  			return;
>  		}