linux-kernel - Re: [PATCH -next v2 RESEND] i2c: designware: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOtMz3P0-y0NX8BM2SpEf3ZnaWO0nRfchRSv-nAJm51JJOn+Cw@mail.gmail.com>
Date:   Mon, 14 Feb 2022 15:01:35 +0100
From:   Jan Dąbroś <jsd@...ihalf.com>
To:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Cc:     Yang Li <yang.lee@...ux.alibaba.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next v2 RESEND] i2c: designware: remove unneeded semicolon

pon., 14 lut 2022 o 14:03 Jarkko Nikula
<jarkko.nikula@...ux.intel.com> napisał(a):
>
> Hi
>
> On 2/14/22 14:47, Yang Li wrote:
> > Eliminate the following coccicheck warnings:
> > ./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon
> > ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon
> >
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> > ---
> >
> > --Changes in v2:
> >    According to Jan's suggestion
> >    Fix the same problem in check_i2c_req_sts() function.
> >
> >   drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> For future contributions: Technically this would be v3 rather than v2
> RESEND since you fixed the typo in commit log noted by Jan for v2.
>
> Please use RESEND only if you'll send exactly the same version for
> instance if you didn't receive any comments for several weeks or some
> recipient was missing from Cc field.
>
> I believe Jan will give Reviewed-by tag to this version too.
>
> Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>

Correct.
Reviewed-by: Jan Dabros <jsd@...ihalf.com>

Best Regards,
Jan