linux-kernel - Re: [PATCH v2] iommu/iova: Separate out rcache init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ygpq9zvzGsFu/FZ1@8bytes.org>
Date:   Mon, 14 Feb 2022 15:45:11 +0100
From:   Joerg Roedel <joro@...tes.org>
To:     John Garry <john.garry@...wei.com>
Cc:     will@...nel.org, mst@...hat.com, jasowang@...hat.com,
        robin.murphy@....com, xieyongji@...edance.com,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, linuxarm@...wei.com
Subject: Re: [PATCH v2] iommu/iova: Separate out rcache init

On Thu, Feb 03, 2022 at 05:59:20PM +0800, John Garry wrote:
> Currently the rcache structures are allocated for all IOVA domains, even if
> they do not use "fast" alloc+free interface. This is wasteful of memory.
> 
> In addition, fails in init_iova_rcaches() are not handled safely, which is
> less than ideal.
> 
> Make "fast" users call a separate rcache init explicitly, which includes
> error checking.
> 
> Signed-off-by: John Garry <john.garry@...wei.com>

Applied, thanks.