linux-kernel - Re: [PATCH] xhci: reduce xhci_handshake timeout in xhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <766b6370-979e-cd3c-cb64-44abce1977d7@gmail.com>
Date:   Mon, 14 Feb 2022 18:45:30 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Pavankumar Kondeti <quic_pkondeti@...cinc.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Sarah Sharp <sarah.a.sharp@...ux.intel.com>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_ugoswami@...cinc.com, Jung Daehwan <dh10.jung@...sung.com>
Subject: Re: [PATCH] xhci: reduce xhci_handshake timeout in xhci_reset

Hello!

On 2/14/22 2:04 PM, Pavankumar Kondeti wrote:

> From: Daehwan Jung <dh10.jung@...sung.com>
> 
> xhci_reset() is called with interrupts disabled. Waiting 10 seconds for
> controller reset and controller ready operations can be fatal to the
> system when controller is timed out. Reduce the timeout to 1 second
> and print a error message when the time out happens.

   Waiting 1 second with IRQs diabled is also hardly acceptable. :-/

> 
> Fixes: 22ceac191211 ("xhci: Increase reset timeout for Renesas 720201 host.")
> Signed-off-by: Daehwan Jung <dh10.jung@...sung.com>
> Signed-off-by: Pavankumar Kondeti <quic_pkondeti@...cinc.com>
[...]

MBR, Sergey