linux-kernel - Re: [PATCH 03/14] nds32: fix access_ok() checks in get/put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgqK1ihlJvRFHJ9h@infradead.org>
Date:   Mon, 14 Feb 2022 09:01:10 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Christoph Hellwig <hch@....de>, linux-arch@...r.kernel.org,
        linux-mm@...ck.org, linux-api@...r.kernel.org, arnd@...db.de,
        linux-kernel@...r.kernel.org, mark.rutland@....com,
        dalias@...c.org, linux-ia64@...r.kernel.org,
        linux-sh@...r.kernel.org, peterz@...radead.org, jcmvbkbc@...il.com,
        guoren@...nel.org, sparclinux@...r.kernel.org,
        linux-hexagon@...r.kernel.org, linux-riscv@...ts.infradead.org,
        will@...nel.org, ardb@...nel.org, linux-s390@...r.kernel.org,
        bcain@...eaurora.org, deller@....de, x86@...nel.org,
        linux@...linux.org.uk, linux-csky@...r.kernel.org,
        mingo@...hat.com, geert@...ux-m68k.org,
        linux-snps-arc@...ts.infradead.org, linux-xtensa@...ux-xtensa.org,
        hca@...ux.ibm.com, linux-alpha@...r.kernel.org,
        linux-um@...ts.infradead.org, linux-m68k@...ts.linux-m68k.org,
        openrisc@...ts.librecores.org, green.hu@...il.com,
        shorne@...il.com, linux-arm-kernel@...ts.infradead.org,
        monstr@...str.eu, tsbogend@...ha.franken.de,
        linux-parisc@...r.kernel.org, nickhu@...estech.com,
        linux-mips@...r.kernel.org, stable@...r.kernel.org,
        dinguyen@...nel.org, ebiederm@...ssion.com, richard@....at,
        akpm@...ux-foundation.org, linuxppc-dev@...ts.ozlabs.org,
        davem@...emloft.net
Subject: Re: [PATCH 03/14] nds32: fix access_ok() checks in get/put_user

On Mon, Feb 14, 2022 at 05:34:41PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The get_user()/put_user() functions are meant to check for
> access_ok(), while the __get_user()/__put_user() functions
> don't.
> 
> This broke in 4.19 for nds32, when it gained an extraneous
> check in __get_user(), but lost the check it needs in
> __put_user().

Can we follow the lead of MIPS (which this was originally copied
from I think) and kill the pointless __get/put_user_check wrapper
that just obsfucate the code?