linux-kernel - [PATCH] inode: fix comment for find_inode_by_ino

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YgqX+MMIhe8g6XC9@agrajag.zerfleddert.de>
Date:   Mon, 14 Feb 2022 18:57:12 +0100
From:   Tobias Jordan <kernel@...e.de>
To:     Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     trivial@...nel.org
Subject: [PATCH] inode: fix comment for find_inode_by_ino_rcu

Fix obvious copy-and-paste relics in comment for find_inode_by_ino_rcu.

Fixes: 3f19b2ab97a9 ("vfs, afs, ext4: Make the inode hash table RCU searchable")

Signed-off-by: Tobias Jordan <kernel@...e.de>
---
 fs/inode.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/fs/inode.c b/fs/inode.c
index 63324df6fa27..c297d57ee9c7 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -1587,19 +1587,11 @@ EXPORT_SYMBOL(find_inode_rcu);
  * find_inode_by_ino_rcu - Find an inode in the inode cache
  * @sb:		Super block of file system to search
  * @ino:	The inode number to match
  *
- * Search for the inode specified by @hashval and @data in the inode cache,
- * where the helper function @test will return 0 if the inode does not match
- * and 1 if it does.  The @test function must be responsible for taking the
- * i_lock spin_lock and checking i_state for an inode being freed or being
- * initialized.
+ * Search for the inode specified by @ino in the inode cache.
  *
- * If successful, this will return the inode for which the @test function
- * returned 1 and NULL otherwise.
- *
- * The @test function is not permitted to take a ref on any inode presented.
- * It is also not permitted to sleep.
+ * If successful, this will return the inode, NULL otherwise.
  *
  * The caller must hold the RCU read lock.
  */
 struct inode *find_inode_by_ino_rcu(struct super_block *sb,
-- 
2.30.2