linux-kernel - Re: [PATCH 1/9] serial: core: move RS485 configuration tasks from drivers into core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220214182311.xaxkdgw5x66vubvv@pengutronix.de>
Date:   Mon, 14 Feb 2022 19:23:11 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Lino Sanfilippo <LinoSanfilippo@....de>
Cc:     alexandre.belloni@...tlin.com, festevam@...il.com,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de,
        richard.genoud@...il.com, gregkh@...uxfoundation.org,
        s.hauer@...gutronix.de, linux@...linux.org.uk,
        nicolas.ferre@...rochip.com, alexandre.torgue@...s.st.com,
        ludovic.desroches@...rochip.com, lukas@...ner.de,
        linux-imx@....com, mcoquelin.stm32@...il.com,
        linux-serial@...r.kernel.org, shawnguo@...nel.org,
        jirislaby@...nel.org, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/9] serial: core: move RS485 configuration tasks from
 drivers into core

Hello Lino,

On Mon, Feb 14, 2022 at 04:09:53PM +0100, Lino Sanfilippo wrote:
> On 14.02.22 at 08:06, Uwe Kleine-König wrote:
> > I was only Cc:d for the imx patch (patch #7) and tried to verify the
> > claim there that "the serial core already assigns the passed
> > configuration to the uart port". That failed when I looked at my kernel
> > tree.
> >
> > So it would be great, if you sent dependencies (or at least a cover
> > letter) to all recipients of a given patch to ease review. Also I want
> > to suggest to mention uart_set_rs485_config() in the commit log of the
> > imx patch (and probably the others) to simplify verifying the claim
> > there.
> 
> Thanks for the review, I will correct the typos in the next version.
> I will also cc you directly for the next version if you dont mind.

I don't mind. I get so many patches by mail, I'm good at ignoring them
;-)

> get_maintainers only spit out "Pengutronix Kernel Team" so I used that
> address for the whole series (including the cover letter).

That's why I eventually found the whole series and could reply to patch
#1.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)