linux-kernel - Re: [PATCH v2] serial: parisc: GSC: fix build when IOSAPIC is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d710a45-1924-1a52-fe48-097deb12cb1c@gmx.de>
Date:   Mon, 14 Feb 2022 19:38:29 +0100
From:   Helge Deller <deller@....de>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     kernel test robot <lkp@...el.com>,
        "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        linux-parisc@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, Jiri Slaby <jirislaby@...nel.org>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH v2] serial: parisc: GSC: fix build when IOSAPIC is not set

On 2/14/22 19:00, Randy Dunlap wrote:
> There is a build error when using a kernel .config file from
> 'kernel test robot' for a different build problem:
>
> hppa64-linux-ld: drivers/tty/serial/8250/8250_gsc.o: in function `.LC3':
> (.data.rel.ro+0x18): undefined reference to `iosapic_serial_irq'
>
> when:
>   CONFIG_GSC=y
>   CONFIG_SERIO_GSCPS2=y
>   CONFIG_SERIAL_8250_GSC=y
>   CONFIG_PCI is not set
>     and hence PCI_LBA is not set.
>   IOSAPIC depends on PCI_LBA, so IOSAPIC is not set/enabled.
>
> Make the use of iosapic_serial_irq() conditional to fix the build error.
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>
> Cc: Helge Deller <deller@....de>
> Cc: linux-parisc@...r.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-serial@...r.kernel.org
> Cc: Jiri Slaby <jirislaby@...nel.org>
> Cc: Johan Hovold <johan@...nel.org>
> Suggested-by: Helge Deller <deller@....de>

Thank you Randy!

Acked-by: Helge Deller <deller@....de>

Since this patch only affects the parisc platform, I've added it
to the parisc for-next tree (with a stable tag), unless people want it
to go through another subsystem tree...

Helge

> ---
> v2: make the call to iosapic_serial_irq() conditional based on
>     CONFIG_ settings (thanks, Helge)
>
>  drivers/tty/serial/8250/8250_gsc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20220211.orig/drivers/tty/serial/8250/8250_gsc.c
> +++ linux-next-20220211/drivers/tty/serial/8250/8250_gsc.c
> @@ -26,7 +26,7 @@ static int __init serial_init_chip(struc
>  	unsigned long address;
>  	int err;
>
> -#ifdef CONFIG_64BIT
> +#if defined(CONFIG_64BIT) && defined(CONFIG_IOSAPIC)
>  	if (!dev->irq && (dev->id.sversion == 0xad))
>  		dev->irq = iosapic_serial_irq(dev);
>  #endif
>