linux-kernel - [PATCH] ASoC: SOF: Makefile: Fix randconfig sof-client build when SND_SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220214070752.21063-1-peter.ujfalusi@linux.intel.com>
Date:   Mon, 14 Feb 2022 09:07:52 +0200
From:   Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>
To:     lgirdwood@...il.com, broonie@...nel.org,
        pierre-louis.bossart@...ux.intel.com,
        ranjani.sridharan@...ux.intel.com
Cc:     alsa-devel@...a-project.org, kai.vehmanen@...ux.intel.com,
        daniel.baluta@....com, tiwai@...e.com,
        linux-kernel@...r.kernel.org, fred.oh@...ux.intel.com
Subject: [PATCH] ASoC: SOF: Makefile: Fix randconfig sof-client build when SND_SOC_SOF=y

From: Peter Ujfalusi <peter.ujfalusi@...il.com>

Intel's kernel test robot found the following randconfig combination:
SND_SOC_SOF=y
SND_SOC_SOF_CLIENT=m

In this the sof-client object is not going to be built into the snd-sof.o
and we will have undefined references to the sof-client functions.

Fixes: 6955d9512d0e ("ASoC: SOF: Introduce IPC SOF client support")
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...il.com>
---
Hi Mark, Pierre,

When the client support was added we did some permutation tests (at least I did)
but missed this combination.
It is a valid one for sure and the proper fix is via the Makefile.

Sorry for mising this

Regards,
Peter

 sound/soc/sof/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/soc/sof/Makefile b/sound/soc/sof/Makefile
index 4d31282c847d..a0459f06c68a 100644
--- a/sound/soc/sof/Makefile
+++ b/sound/soc/sof/Makefile
@@ -2,7 +2,9 @@
 
 snd-sof-objs := core.o ops.o loader.o ipc.o pcm.o pm.o debug.o topology.o\
 		control.o trace.o iomem-utils.o sof-audio.o stream-ipc.o
-snd-sof-$(CONFIG_SND_SOC_SOF_CLIENT) += sof-client.o
+ifneq ($(CONFIG_SND_SOC_SOF_CLIENT),)
+snd-sof-objs += sof-client.o
+endif
 
 snd-sof-$(CONFIG_SND_SOC_SOF_COMPRESS) += compress.o
 
-- 
2.35.1