linux-kernel - Re: [PATCH 13/23] drm/rockchip: Make use of the helper component_compare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3640952.nfqboWGjmy@diego>
Date:   Mon, 14 Feb 2022 09:03:04 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, Yong Wu <yong.wu@...iatek.com>
Cc:     James Wang <james.qian.wang@....com>,
        Liviu Dudau <liviu.dudau@....com>,
        iommu@...ts.linux-foundation.org,
        Matthias Brugger <matthias.bgg@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        linux-kernel@...r.kernel.org, Joerg Roedel <joro@...tes.org>,
        Will Deacon <will@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        linux-mediatek@...ts.infradead.org,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Stephen Boyd <sboyd@...nel.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Robin Murphy <robin.murphy@....com>,
        Tomasz Figa <tfiga@...omium.org>, srv_heupstream@...iatek.com,
        Rob Clark <robdclark@...il.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        Yong Wu <yong.wu@...iatek.com>,
        Sandy Huang <hjc@...k-chips.com>,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH 13/23] drm/rockchip: Make use of the helper component_compare_dev

Am Montag, 14. Februar 2022, 07:08:09 CET schrieb Yong Wu:
> Use the common compare helper from component.
> 
> Cc: Sandy Huang <hjc@...k-chips.com>
> Cc: "Heiko St¨¹bner" <heiko@...ech.de>
> Cc: linux-rockchip@...ts.infradead.org
> Signed-off-by: Yong Wu <yong.wu@...iatek.com>

Acked-by: Heiko Stuebner <heiko@...ech.de>

> ---
>  drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> index bec207de4544..3c2f2d6ecc36 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> @@ -290,11 +290,6 @@ int rockchip_drm_endpoint_is_subdriver(struct device_node *ep)
>  	return false;
>  }
>  
> -static int compare_dev(struct device *dev, void *data)
> -{
> -	return dev == (struct device *)data;
> -}
> -
>  static void rockchip_drm_match_remove(struct device *dev)
>  {
>  	struct device_link *link;
> @@ -321,7 +316,7 @@ static struct component_match *rockchip_drm_match_add(struct device *dev)
>  				break;
>  
>  			device_link_add(dev, d, DL_FLAG_STATELESS);
> -			component_match_add(dev, &match, compare_dev, d);
> +			component_match_add(dev, &match, component_compare_dev, d);
>  		} while (true);
>  	}
>  
>