linux-kernel - Re: [GIT PULL] sched/urgent for 5.17-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgoWoh6pIzlsQx6d@hirez.programming.kicks-ass.net>
Date:   Mon, 14 Feb 2022 09:45:22 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Borislav Petkov <bp@...e.de>,
        Tadeusz Struk <tadeusz.struk@...aro.org>,
        x86-ml <x86@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
        zhangqiao22@...wei.com, tj@...nel.org, dietmar.eggemann@....com
Subject: Re: [GIT PULL] sched/urgent for 5.17-rc4

On Sun, Feb 13, 2022 at 10:02:22AM -0800, Linus Torvalds wrote:
> On Sun, Feb 13, 2022 at 4:37 AM Borislav Petkov <bp@...e.de> wrote:
> >
> > Tadeusz Struk (1):
> >       sched/fair: Fix fault in reweight_entity
> 
> I've pulled this, but this really smells bad to me.
> 
> If set_load_weight() can see a process that hasn't even had the
> runqueue pointer set yet, then what keeps *others* from the same
> thing?

Urgh, I think you're right, the moment we enter the pidhash and become
visible we should be complete. That means the previous commit
(4ef0c5c6b5ba) is buggered... Let me try and make sense of all that
cgroup stuff again :-(