linux-kernel - Re: [PATCH v3 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgofoEOPuiB4LbQT@smile.fi.intel.com>
Date:   Mon, 14 Feb 2022 11:23:44 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Nuno Sá <nuno.sa@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v3 1/3] iio: temperature: ltc2983: Don't hard code
 defined constants in messages

On Sun, Feb 13, 2022 at 05:55:59PM +0000, Jonathan Cameron wrote:
> On Thu, 10 Feb 2022 15:55:20 +0200
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> 
> > In a couple of messages the constants, which have their definitions,
> > are hard coded into the message text. Unhardcode them.
> > 
> > While at it, add a trailing \n where it's currently missing.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Reviewed-by: Nuno Sá <nuno.sa@...log.com>
> 
> Mostly so I can remember what is going on with this patch,
> Nuno is OoO and planning to test this series when he returns.
> 
> Given that I'll wait on Nuno's testing.

Me too :-)

-- 
With Best Regards,
Andy Shevchenko