linux-kernel - Re: [PATCH] firmware_loader: EXTRA_FIRMWARE does not support compressed files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgsHtdqm3xRU+QUD@bombadil.infradead.org>
Date:   Mon, 14 Feb 2022 17:53:57 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] firmware_loader: EXTRA_FIRMWARE does not support
 compressed files

On Mon, Feb 14, 2022 at 02:23:11PM -0800, Randy Dunlap wrote:
> Document in the firmware loader Kconfig help text that firmware image
> file compression is not supported for builtin EXTRA_FIRMWARE files so
> that someone does not waste time trying that.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> ---
> Yeah, I wasted some time trying to use an xz compressed file
> as builtin EXTRA_FIRMWARE, 

Curious *why* you are using EXTRA_FIRMWARE BTW.

> so try to prevent someone else from
> doing that.

Acked-by: Luis Chamberlain <mcgrof@...nel.org>

  Luis
> 
>  drivers/base/firmware_loader/Kconfig |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> --- linux-next-20220214.orig/drivers/base/firmware_loader/Kconfig
> +++ linux-next-20220214/drivers/base/firmware_loader/Kconfig
> @@ -60,6 +60,8 @@ config EXTRA_FIRMWARE
>  	  image since it combines both GPL and non-GPL work. You should
>  	  consult a lawyer of your own before distributing such an image.
>  
> +	  NOTE: Compressed files are not supported in EXTRA_FIRMWARE.
> +
>  config EXTRA_FIRMWARE_DIR
>  	string "Firmware blobs root directory"
>  	depends on EXTRA_FIRMWARE != ""
> @@ -169,6 +171,9 @@ config FW_LOADER_COMPRESS
>  	  be compressed with either none or crc32 integrity check type (pass
>  	  "-C crc32" option to xz command).
>  
> +	  Compressed firmware support does not apply to firmware images
> +	  that are built into the kernel image (CONFIG_EXTRA_FIRMWARE).
> +
>  config FW_CACHE
>  	bool "Enable firmware caching during suspend"
>  	depends on PM_SLEEP