linux-kernel - Re: [PATCH v3] iio: accel: adxl345: Add ACPI HID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Feb 2022 17:31:48 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] iio: accel: adxl345: Add ACPI HID table

On Tue, Feb 15, 2022 at 1:30 PM Kai-Heng Feng
<kai.heng.feng@...onical.com> wrote:
> On Tue, Feb 15, 2022 at 4:28 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Tue, Feb 15, 2022 at 6:20 AM Kai-Heng Feng
> > <kai.heng.feng@...onical.com> wrote:

...

> > > +       { "ADS0345:00", ADXL345 },
> >
> > This is wrong. First of all, on the left side you put the device
> > instance name (which must not be in the ID tables, since the device
> > instance name is "ID + instance number"). Second, the motivation of
> > this is not clear, if the device is enumerated by ACPI, why do you
> > care about board code?
>
> I was uncertain on this at first, but later I saw some drivers use
> this form (*:00) too, so I just followed through.

Those "drivers" are actually so called board files, i.o.w. hard coded
pieces of what firmware(s) missed. That's why they are using device
instance name(s) instead of the device IDs.

-- 
With Best Regards,
Andy Shevchenko