linux-kernel - Re: [PATCH] ARM: at91: debug: add lan966 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220215154625.826450-1-michael@walle.cc>
Date:   Tue, 15 Feb 2022 16:46:25 +0100
From:   Michael Walle <michael@...le.cc>
To:     kavyasree.kotagiri@...rochip.com
Cc:     alexandre.belloni@...tlin.com, linus.walleij@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux@...linux.org.uk, Michael Walle <michael@...le.cc>
Subject: Re: [PATCH] ARM: at91: debug: add lan966 support

Hi,

> Add support for low-level debugging on FLEXCOM3 USART of
> LAN966 SoC.
> 
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>
> ---
>  arch/arm/Kconfig.debug | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 976315dea958..7989d0633188 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -210,6 +210,14 @@ choice
>  		  Say Y here if you want kernel low-level debugging support
>  		  on the FLEXCOM3 port of SAMA7G5.
>  
> +        config DEBUG_AT91_LAN966_FLEXCOM3

Can we use DEBUG_AT91_LAN966_FLEXCOM here and provide a table with
all the different offsets for all flexcoms, and maybe default to flexcom0
(or flexcom3, I'm not sure).

> +                bool "Kernel low-level debugging on LAN966 FLEXCOM3 USART"
> +                select DEBUG_AT91_UART
> +                depends on SOC_LAN966
> +                help
> +                  Say Y here if you want kernel low-level debugging support
> +                  on the FLEXCOM3 port of LAN966.
> +
>  	config DEBUG_BCM2835
>  		bool "Kernel low-level debugging on BCM2835 PL011 UART"
>  		depends on ARCH_BCM2835 && ARCH_MULTI_V6
> @@ -1685,6 +1693,7 @@ config DEBUG_UART_PHYS
>  	default 0xd4017000 if DEBUG_MMP_UART2
>  	default 0xd4018000 if DEBUG_MMP_UART3
>  	default 0xe0000000 if DEBUG_SPEAR13XX
> +	default 0xe0040200 if DEBUG_AT91_LAN966_FLEXCOM3

This is the base address of the flexcom0 uart, not flexcom3.

-michael