linux-kernel - Re: [PATCH v3 00/10] iommu cleanup and refactoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d817995-f89b-a1de-6aff-9a2bfe91367f@linux.intel.com>
Date:   Tue, 15 Feb 2022 10:05:42 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Joerg Roedel <joro@...tes.org>
Cc:     baolu.lu@...ux.intel.com, Jason Gunthorpe <jgg@...dia.com>,
        Christoph Hellwig <hch@...radead.org>,
        Ben Skeggs <bskeggs@...hat.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Ashok Raj <ashok.raj@...el.com>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Eric Auger <eric.auger@...hat.com>,
        Liu Yi L <yi.l.liu@...el.com>,
        Jacob jun Pan <jacob.jun.pan@...el.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 00/10] iommu cleanup and refactoring

Hi Joerg,

On 2/14/22 10:14 PM, Joerg Roedel wrote:
> On Mon, Feb 14, 2022 at 09:55:28AM +0800, Lu Baolu wrote:
>> v3:
>>   - Remove ops check when dev_iommu_ops() is used.
>>   - This version of series is available on github:
>>     https://github.com/LuBaolu/intel-iommu/commits/iommu-domain-ops-v3
>>
>> Lu Baolu (10):
>>    iommu/vt-d: Remove guest pasid related callbacks
>>    iommu: Remove guest pasid related interfaces and definitions
>>    iommu/vt-d: Remove aux-domain related callbacks
>>    iommu: Remove aux-domain related interfaces and iommu_ops
>>    iommu: Remove apply_resv_region
>>    drm/nouveau/device: Get right pgsize_bitmap of iommu_domain
>>    iommu: Use right way to retrieve iommu_ops
>>    iommu: Remove unused argument in is_attach_deferred
>>    iommu: Use dev_iommu_ops() helper
>>    iommu: Split struct iommu_ops
> 
> Really cool, thanks for doing this, Baolu! I am currently running some
> tests on this series to make sure there are no build breakages. And I
> agree with Jason that:
> 
> 	iommu: Use right way to retrieve iommu_ops and
> 	iommu: Use dev_iommu_ops() helper
> 
> can be combined into one patch. Splitting iommu_ops was something I have
> been thinking about for some time, so thanks again for doing this.

You are welcome!

Do you want me to send a new version with below changes:

- Remove WARN_ON() in dev_iommu_ops();
- Merge above two patches.

Or, you can change above yourself?

> 
> Regards,
> 
> 	Joerg

Best regards,
baolu