linux-kernel - Re: [PATCH][next] treewide: Replace zero-length arrays with flexible-array members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202202151016.C0471D6E@keescook>
Date:   Tue, 15 Feb 2022 10:17:40 -0800
From:   Kees Cook <keescook@...omium.org>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc:     GR-QLogic-Storage-Upstream@...vell.com,
        linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-ia64@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-sh@...r.kernel.org, sparclinux@...r.kernel.org,
        linux-um@...ts.infradead.org, linux-xtensa@...ux-xtensa.org,
        linux-crypto@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
        coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-scsi@...r.kernel.org,
        target-devel@...r.kernel.org, mpi3mr-linuxdrv.pdl@...adcom.com,
        linux-staging@...ts.linux.dev,
        linux-rpi-kernel@...ts.infradead.org, sparmaintainer@...sys.com,
        linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
        linux-ext4@...r.kernel.org, linux-acpi@...r.kernel.org,
        devel@...ica.org, linux-arch@...r.kernel.org, linux-mm@...ck.org,
        greybus-dev@...ts.linaro.org, linux-i3c@...ts.infradead.org,
        linux-rdma@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-perf-users@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] treewide: Replace zero-length arrays with
 flexible-array members

On Tue, Feb 15, 2022 at 11:47:43AM -0600, Gustavo A. R. Silva wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use “flexible array members”[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
> 
> This code was transformed with the help of Coccinelle:
> (next-20220214$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file script.cocci --include-headers --dir . > output.patch)
> 
> @@
> identifier S, member, array;
> type T1, T2;
> @@
> 
> struct S {
>   ...
>   T1 member;
>   T2 array[
> - 0
>   ];
> };

These all look trivially correct to me. Only two didn't have the end of
the struct visible in the patch, and checking those showed them to be
trailing members as well, so:

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook