linux-kernel - Re: [PATCH] sh: Convert nommu io{re,un}map() to static inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220215191608.GA25076@lst.de>
Date:   Tue, 15 Feb 2022 20:16:08 +0100
From:   Christoph Hellwig <hch@....de>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>, Christoph Hellwig <hch@....de>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        kernel test robot <lkp@...el.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Arnd Bergmann <arnd@...db.de>, linux-sh@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sh: Convert nommu io{re,un}map() to static inline
 functions

On Tue, Feb 15, 2022 at 09:51:05AM +0100, Geert Uytterhoeven wrote:
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Fixes: 13f1fc870dd74713 ("sh: move the ioremap implementation out of line")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>

> ---
> This is actually the third time this change was made, as Christoph
> converted iounmap() to a macro before in commit 98c90e5ea34e98bd ("sh:
> remove __iounmap"), reverting commit 733f0025f0fb43e3 ("sh: prevent
> warnings when using iounmap").
> 
> Probably sh-nommu should include <asm-generic/io.h>, but that would
> require a lot more changes.

I don't think it would be all that bad.  But between the breakage and
the fact that sh is almost unmaintained let's get the quick fix in if
we can..