linux-kernel - Re: [PATCH] Input: psmouse - set up dependency between PS/2 and SMBus companions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2adc3231-2f5c-78c0-7a68-e5a8a1363b55@leemhuis.info>
Date:   Tue, 15 Feb 2022 21:53:50 +0100
From:   Thorsten Leemhuis <regressions@...mhuis.info>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org
Cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Rajat Jain <rajatja@...gle.com>, Wolfram Sang <wsa@...nel.org>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Hugh Dickins <hughd@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: psmouse - set up dependency between PS/2 and SMBus
 companions



On 15.02.22 21:42, Dmitry Torokhov wrote:
> When we switch from emulated PS/2 to native (RMI4 or Elan) protocols, we
> create SMBus companion devices that are attached to I2C/SMBus controllers.
> However, when suspending and resuming, we also need to make sure that we
> take into account the PS/2 device they are associated with, so that PS/2
> device is suspended after the companion and resumed before it, otherwise
> companions will not work properly. Before I2C devices were marked for
> asynchronous suspend/resume, this ordering happened naturally, but now we
> need to enforce it by establishing device links, with PS/2 devices being
> suppliers and SMBus companions being consumers.
> 
> Fixes: 172d931910e1 ("i2c: enable async suspend/resume on i2c client devices")
> Reported-and-tested-by: Hugh Dickins <hughd@...gle.com>
> Tested-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

If you respin or commit this patch, could you please add the link to the
report, as explained in 'Documentation/process/submitting-patches.rst'
and 'Documentation/process/5.Posting.rst':

Link:
https://lore.kernel.org/r/89456fcd-a113-4c82-4b10-a9bcaefac68f@google.com

This would be helpful for me, as this is a regression tracked by
regzbot, my Linux kernel regression tracking bot, which then is able to
assign threads like this with the regression report and mark the
regression as resolved once the fix lands in the appropriate tree. tia!

Ciao, Thorsten

#regzbot ^backmonitor:
https://lore.kernel.org/r/89456fcd-a113-4c82-4b10-a9bcaefac68f@google.com