linux-kernel - Re: [PATCH v2] printk: Set console_set_on_cmdline=1 when __add_preferred_console() is called with user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ygsa7gfqlhZVWdDb@google.com>
Date:   Tue, 15 Feb 2022 12:15:58 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Andre Kalb <andre.kalb@....de>
Cc:     pmladek@...e.com, john.ogness@...utronix.de,
        linux-kernel@...r.kernel.org, rostedt@...dmis.org,
        senozhatsky@...omium.org
Subject: Re: [PATCH v2] printk: Set console_set_on_cmdline=1 when
 __add_preferred_console() is called with user_specified == true

On (22/02/14 14:21), Andre Kalb wrote:
> +static void set_user_specified(struct console_cmdline *c, bool user_specified)
> +{
> +	if (!user_specified)
> +		return;
> +
> +	c->user_specified = true;
> +	console_set_on_cmdline = 1;
> +}

In original code we always set c->user_specified. Is it guaranteed that
->user_specified is properly initialized to 0? Maybe can do something like:

static void set_user_specified(struct console_cmdline *c, bool user_specified)
{
	c->user_specified = user_specified;

	if (!user_specified)
		return;

	console_set_on_cmdline = 1;
}