linux-kernel - Re: [PATCH v1 1/1] perf/smmuv3: Don't cast parameter in bit operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164494388717.3761559.1060651484914816360.b4-ty@kernel.org>
Date:   Tue, 15 Feb 2022 23:18:21 +0000
From:   Will Deacon <will@...nel.org>
To:     linux-kernel@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     catalin.marinas@....com, kernel-team@...roid.com,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v1 1/1] perf/smmuv3: Don't cast parameter in bit operations

On Wed, 9 Feb 2022 20:47:58 +0200, Andy Shevchenko wrote:
> While in this particular case it would not be a (critical) issue,
> the pattern itself is bad and error prone in case somebody blindly
> copies to their code.
> 
> Don't cast parameter to unsigned long pointer in the bit operations.
> Instead copy to a local variable on stack of a proper type and use.
> 
> [...]

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/1] perf/smmuv3: Don't cast parameter in bit operations
      https://git.kernel.org/will/c/8ddf4eff71e1

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev