linux-kernel - Re: [PATCH net-next] net: marvell: prestera: Fix includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220214211743.6fbd3075@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 14 Feb 2022 21:17:43 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yevhen Orlov <yevhen.orlov@...ision.eu>
Cc:     netdev@...r.kernel.org,
        Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        Mickey Rachamim <mickeyr@...vell.com>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Taras Chornyi <tchornyi@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Vadym Kochan <vadym.kochan@...ision.eu>,
        Andrii Savka <andrii.savka@...ision.eu>,
        Serhiy Boiko <serhiy.boiko@...ision.eu>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: marvell: prestera: Fix includes

On Mon, 14 Feb 2022 03:12:28 +0200 Yevhen Orlov wrote:
> Include prestera.h in prestera_hw.h, because it may contain common
> definitions.

*May*? Is prestera_hw.h using definitions from prestera.h today?
Dependencies between header files are best avoided completely.