linux-kernel - Re: [PATCH] nvme: Fix missing error code in nvme_configure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <183f319e-613d-5318-25b2-2c90ef4fdee5@wanadoo.fr>
Date:   Tue, 15 Feb 2022 07:22:11 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Keith Busch <kbusch@...nel.org>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     axboe@...com, hch@....de, sagi@...mberg.me,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] nvme: Fix missing error code in
 nvme_configure_directives()

Le 15/02/2022 à 04:55, Keith Busch a écrit :
> On Tue, Feb 15, 2022 at 11:36:32AM +0800, Jiapeng Chong wrote:
>> The error code is missing in this code scenario, add the error code
>> '-EINVAL' to the return value 'ret'.
>>
>> Eliminate the follow smatch warning:
>>
>> drivers/nvme/host/core.c:780 nvme_configure_directives() warn: missing
>> error code 'ret'.
> 
> Nak, the code is correct as-is, just like it was the previous time you
> posted this patch:
> 
>    http://lists.infradead.org/pipermail/linux-nvme/2021-September/027339.html
> 

Hi,

maybe an explicit 'ret = 0;' (and eventually a comment saying why) would 
help here?

The code really looks like an error handling path (and will keep getting 
some patches for it because of bots).

Just my 2c.

CJ