linux-kernel - Re: [PATCH] tee: amdtee: Make use of the helper macro LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Feb 2022 07:49:41 +0100
From:   Jens Wiklander <jens.wiklander@...aro.org>
To:     Rijo Thomas <Rijo-john.Thomas@....com>
Cc:     Cai Huoqing <cai.huoqing@...ux.dev>,
        Sumit Garg <sumit.garg@...aro.org>,
        Devaraj Rangasamy <Devaraj.Rangasamy@....com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        op-tee@...ts.trustedfirmware.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tee: amdtee: Make use of the helper macro LIST_HEAD()

On Wed, Feb 9, 2022 at 8:16 AM Rijo Thomas <Rijo-john.Thomas@....com> wrote:
>
>
>
> On 2/9/2022 8:57 AM, Cai Huoqing wrote:
> > Replace "struct list_head head = LIST_HEAD_INIT(head)" with
> > "LIST_HEAD(head)" to simplify the code.
> >
> > Signed-off-by: Cai Huoqing <cai.huoqing@...ux.dev>
> > ---
> >  drivers/tee/amdtee/call.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tee/amdtee/call.c b/drivers/tee/amdtee/call.c
> > index 07f36ac834c8..cec6e70f0ac9 100644
> > --- a/drivers/tee/amdtee/call.c
> > +++ b/drivers/tee/amdtee/call.c
> > @@ -122,7 +122,7 @@ static int amd_params_to_tee_params(struct tee_param *tee, u32 count,
> >  }
> >
> >  static DEFINE_MUTEX(ta_refcount_mutex);
> > -static struct list_head ta_list = LIST_HEAD_INIT(ta_list);
> > +static LIST_HEAD(ta_list);
> >
>
> Reviewed-by: Rijo Thomas <Rijo-john.Thomas@....com>

I'm picking up this.

Thanks,
Jens

>
> Thanks,
> Rijo
>
> >  static u32 get_ta_refcount(u32 ta_handle)
> >  {
> >