linux-kernel - Re: [ANNOUNCE] autofs 5.1.8 release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1c21e74-85b0-0040-deb7-811a6fa7b312@altlinux.org>
Date:   Tue, 15 Feb 2022 10:56:26 +0300
From:   Stanislav Levin <slev@...linux.org>
To:     NeilBrown <neilb@...e.de>, Ian Kent <raven@...maw.net>
Cc:     autofs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [ANNOUNCE] autofs 5.1.8 release



10.02.2022 00:59, NeilBrown пишет:
> On Tue, 19 Oct 2021, Ian Kent wrote:
>> Hi all,
>>
>> It's time for a release, autofs-5.1.8.
>>
> ...
>> - also require TCP_REQUESTED when setting NFS port.
> 
> Unfortunately that last patch is buggy.  TCP_REQUESTED is masked out in
> the caller.
> 
> Maybe the following is best.
> 
> NeilBrown
> 
> From: NeilBrown <neilb@...e.de>
> Subject: [PATCH] Test TCP request correctly in nfs_get_info()
> 
> The TCP_REQUESTED flag is masked out by the caller, so it never gets to
> nfs_get_info().
> We can test if TCP was requested by examining the 'proto' parameter.
> 
> Signed-off-by: NeilBrown <neilb@...e.de>
> 
> diff --git a/modules/replicated.c b/modules/replicated.c
> index 09075dd0c1b4..3ac7ee432e73 100644
> --- a/modules/replicated.c
> +++ b/modules/replicated.c
> @@ -291,7 +291,7 @@ static unsigned int get_nfs_info(unsigned logopt, struct host *host,
>  
>  	rpc_info->proto = proto;
>  	if (port < 0) {
> -		if ((version & NFS4_REQUESTED) && (version & TCP_REQUESTED))
> +		if ((version & NFS4_REQUESTED) && (proto == IPPROTO_TCP))
>  			rpc_info->port = NFS_PORT;
>  		else
>  			port = 0;
> 


This seems duplicate of https://www.spinics.net/lists/autofs/msg02389.html



Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)