linux-kernel - Re: [PATCH -next] scsi: hisi_sas: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a756b22a-5eb5-a883-c9ca-c2345493dee7@huawei.com>
Date:   Tue, 15 Feb 2022 08:03:29 +0000
From:   John Garry <john.garry@...wei.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, <jejb@...ux.ibm.com>
CC:     <martin.petersen@...cle.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] scsi: hisi_sas: Remove unnecessary print function
 dev_err()

On 15/02/2022 02:05, Yang Li wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
> 
> Eliminate the follow coccicheck warnings:
> ./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1661:3-10: line 1661 is
> redundant because platform_get_irq() already prints an error
> ./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1642:4-11: line 1642 is
> redundant because platform_get_irq() already prints an error
> ./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1679:3-10: line 1679 is
> redundant because platform_get_irq() already prints an error
> 
> Reported-by: Abaci Robot<abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li<yang.lee@...ux.alibaba.com>

Acked-by: John Garry <john.garry@...wei.com>