linux-kernel - Re: [PATCH] tty: serial: 8250: add missing pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ygt4aUMVKM8ZcW/5@smile.fi.intel.com>
Date:   Tue, 15 Feb 2022 11:54:49 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     Qing Wang <wangqing@...o.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: serial: 8250: add missing pci_dev_put() before
 return

On Tue, Feb 15, 2022 at 07:02:57AM +0100, Jiri Slaby wrote:
> On 15. 02. 22, 6:55, Jiri Slaby wrote:
> > On 15. 02. 22, 3:00, Qing Wang wrote:
> > > From: Wang Qing <wangqing@...o.com>
> > > 
> > > pci_get_slot() increases its reference count, the caller must
> > > decrement the reference count by calling pci_dev_put()

Wang, thank you for the report!

...

> > What about the "return -ENODEV" few lines above?
> 
> On the top of that, the code stores the pointer to the dev:
> param->dma_dev = &dma_dev->dev;
> 
> So we should likely put the device in ->exit(), not ->setup().

I think I may fix all these and send a new version.

-- 
With Best Regards,
Andy Shevchenko