linux-kernel - Re: [PATCH v1 1/1] serial: 8250_mid: Balance reference count for PCI DMA device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YguAncl92hV2vUkm@smile.fi.intel.com>
Date:   Tue, 15 Feb 2022 12:29:49 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Qing Wang <wangqing@...o.com>
Subject: Re: [PATCH v1 1/1] serial: 8250_mid: Balance reference count for PCI
 DMA device

On Tue, Feb 15, 2022 at 11:11:41AM +0100, Jiri Slaby wrote:
> On 15. 02. 22, 11:09, Andy Shevchenko wrote:
> > The pci_get_slot() increases its reference count, the caller
> > must decrement the reference count by calling pci_dev_put().

> And what about the -EINVAL case?

What about it? The ->probe() calls ->exit() in its error path.
Or did I miss something?

-- 
With Best Regards,
Andy Shevchenko