[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dfa69bbf-726c-558a-b929-aa97dd6590aa@huawei.com>
Date: Tue, 15 Feb 2022 09:27:37 +0800
From: "liuqi (BA)" <liuqi115@...wei.com>
To: John Garry <john.garry@...wei.com>, Qi Liu <liuqi115@...wei.com>,
"will@...nel.org" <will@...nel.org>,
"mark.rutland@....com" <mark.rutland@....com>
CC: "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Zhangshaokun <zhangshaokun@...ilicon.com>,
Linuxarm <linuxarm@...wei.com>,
<linux-perf-users@...r.kernel.org>
Subject: Re: [PATCH 2/2] perf jevents: Add support for HiSilicon CPA PMU
aliasing
On 2022/2/14 20:04, John Garry wrote:
> On 14/02/2022 11:42, Qi Liu wrote:
>> Add support for HiSilicon CPA PMU aliasing.
>>
>> The kernel driver is in drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c
>>
>> Signed-off-by: Qi Liu<liuqi115@...wei.com>
>
> You realy should cc the perf tool list and maintainers there also.
>
> Reviewed-by: John Garry <john.garry@...wei.com>
>
>> + },
>> + {
>> + "MetricExpr": "(p0_wr_dat * 64 + p0_rd_dat_64b * 64 +
>> p0_rd_dat_32b * 32) / cpa_cycles",
>> + "BriefDescription": "Average bandwidth of CPA Port 0",
>> + "MetricGroup": "CPA",
>
Hi john,
> nit: maybe this should have a more distrinct name
got it, will change metric's name next version.
>
>> + "MetricName": "p0_avg_bw",
>> + "Compat": "0x00000030",
>
> JFYI, I have a rewrite of the perf tool system pmu metric support that
> will not require us to add the compat here.
>
great! I'm very glad to test it using CPA PMU.
Thanks,
Qi
>> + "Unit": "hisi_sicl,cpa"
>
> Thanks,
> John
> .
Powered by blists - more mailing lists