linux-kernel - Re: [PATCH v5 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yguf5bwRkqolW0+/@kuha.fi.intel.com>
Date:   Tue, 15 Feb 2022 14:43:17 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Xin Ji <xji@...logixsemi.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        bliang@...logixsemi.com, qwen@...logixsemi.com,
        jli@...logixsemi.com, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v5 2/2] usb: typec: anx7411: Add Analogix PD ANX7411
 support

On Tue, Feb 15, 2022 at 01:43:00PM +0800, Xin Ji wrote:
> On Wed, Feb 09, 2022 at 03:31:26PM +0200, Heikki Krogerus wrote:
> > On Tue, Feb 08, 2022 at 05:16:21PM +0800, Xin Ji wrote:
> > > Add driver for analogix ANX7411 USB Type-C DRP port controller.
> > 
> > We already have the driver drivers/usb/typec/tcpm/tcpci.c for port
> > controllers.
> > 
> > If you need a glue layer - if there is something specific that you
> > need to do with ANX7411 that is not completely TCPC compliant - use
> > drivers/usb/typec/tcpm/tcpci_*.c as examples.
> Hi heikki, ANX7411 PD controller has 2 applications, the one has embeded
> internal firmware, the other is not have. The currently upstream patch
> is for the first way, driver mustn't use TCPCI framework(embeded firmware
> will control all the TCPCI register). The second way(erased internaly
> firmware) can work under TCPCI framework.

Ah, so it has a microcontroller. Fair enough. I'll take another
look at your patch.

thanks,

-- 
heikki