linux-kernel - Re: [PATCH v2] mm: clean up hwpoison page cache page in fault path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f70cc26ccc92d099f1080e4c57ab44709bafd68.camel@surriel.com>
Date:   Mon, 14 Feb 2022 20:37:26 -0500
From:   Rik van Riel <riel@...riel.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, kernel-team@...com,
        linux-mm@...ck.org, Miaohe Lin <linmiaohe@...wei.com>,
        Mel Gorman <mgorman@...e.de>,
        Johannes Weiner <hannes@...xchg.org>,
        Matthew Wilcox <willy@...radead.org>,
        Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
        Naoya Horiguchi <naoya.horiguchi@....com>
Subject: Re: [PATCH v2] mm: clean up hwpoison page cache page in fault path

On Mon, 2022-02-14 at 15:24 -0800, Andrew Morton wrote:
> 
> > Subject: [PATCH v2] mm: clean up hwpoison page cache page in fault
> > path
> 
> At first scan I thought this was a code cleanup.
> 
> I think I'll do s/clean up/invalidate/.
> 
OK, that sounds good.

> On Sat, 12 Feb 2022 21:37:40 -0500 Rik van Riel <riel@...riel.com>
> wrote:
> 
> > Sometimes the page offlining code can leave behind a hwpoisoned
> > clean
> > page cache page.
> 
> Is this correct behaviour?

It is not desirable, and the soft page offlining code
tries to invalidate the page, but I don't think overhauling
the way we lock and refcount page cache pages just to make
offlining them more reliable would be worthwhile, when we
already have a branch in the page fault handler to deal with
these pages, anyway.

> > This can lead to programs being killed over and over
> > and over again as they fault in the hwpoisoned page, get killed,
> > and
> > then get re-spawned by whatever wanted to run them.
> > 
> > This is particularly embarrassing when the page was offlined due to
> > having too many corrected memory errors. Now we are killing tasks
> > due to them trying to access memory that probably isn't even
> > corrupted.
> > 
> > This problem can be avoided by invalidating the page from the page
> > fault handler, which already has a branch for dealing with these
> > kinds of pages. With this patch we simply pretend the page fault
> > was successful if the page was invalidated, return to userspace,
> > incur another page fault, read in the file from disk (to a new
> > memory page), and then everything works again.
> 
> Is this worth a cc:stable?

Maybe. I don't know how far back this issue goes...

-- 
All Rights Reversed.

Download attachment "signature.asc" of type "application/pgp-signature" (485 bytes)