linux-kernel - Re: [PATCH v3 09/10] iommu: Use dev_iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43855d9f-f60a-0bb0-088d-cf0b12defb79@linux.intel.com>
Date:   Tue, 15 Feb 2022 09:39:21 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Jason Gunthorpe <jgg@...dia.com>
Cc:     baolu.lu@...ux.intel.com, Joerg Roedel <joro@...tes.org>,
        Christoph Hellwig <hch@...radead.org>,
        Ben Skeggs <bskeggs@...hat.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Ashok Raj <ashok.raj@...el.com>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Eric Auger <eric.auger@...hat.com>,
        Liu Yi L <yi.l.liu@...el.com>,
        Jacob jun Pan <jacob.jun.pan@...el.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 09/10] iommu: Use dev_iommu_ops() helper

On 2/14/22 9:26 PM, Jason Gunthorpe wrote:
> On Mon, Feb 14, 2022 at 09:55:37AM +0800, Lu Baolu wrote:
>> This converts all the feasible instances of dev->bus->iommu_ops to
>> dev_iommu_ops() in order to make the operation of obtaining iommu_ops
>> from a device consistent. The dev_iommu_ops() warns on NULL ops, so
>> we don't need to keep the confusing ops check.
>>
>> Suggested-by: Robin Murphy<robin.murphy@....com>
>> Signed-off-by: Lu Baolu<baolu.lu@...ux.intel.com>
>> ---
>>   drivers/iommu/iommu.c | 30 ++++++++++++++----------------
>>   1 file changed, 14 insertions(+), 16 deletions(-)
> I thought you were going to squish this into the prior patch?

I will merge this two patches in the next version. I made them separated
in this series just for ease of review.

Best regards,
baolu