linux-kernel - RE: [PATCH v3] nvme/pci: Add quick suspend quirk for Sc7280 Platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b291987cf914f119788c42b32a08a12@quicinc.com>
Date:   Wed, 16 Feb 2022 16:07:05 +0000
From:   "Nitin Rawat (QUIC)" <quic_nitirawa@...cinc.com>
To:     Christoph Hellwig <hch@...radead.org>,
        Vidya Sagar <vidyas@...dia.com>
CC:     Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Sagi Grimberg <sagi@...mberg.me>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Sajida Bhanu (Temp) (QUIC)" <quic_c_sbhanu@...cinc.com>
Subject: RE: [PATCH v3] nvme/pci: Add quick suspend quirk for Sc7280 Platform

Hi Christoph/Keith/Rafael

Since we are giving control to PCIe (NVMe power rails control), it can vary from platform to platform.
More over, PCIe driver doesn't control these power rails directly from PCIe driver, they tie nvme supply with one of the pcie supply and control them together. 
So i think it would be better to either have quirk based on platform or always setting simple suspend and platform which needs full suspend can update it through some means. 

Based on below link, Looks like this can be across platform ...vidya also mention similar concern for tegra platform.  
https://lore.kernel.org/lkml/20220209202639.GB1616420@dhcp-10-100-145-180.wdc.com/T/#md10b0108b3ccbb1254fe0ad8dbb6e98044a8820b

Please let me know your opinions.

Thanks,
Nitin
-----Original Message-----
From: Christoph Hellwig <hch@...radead.org> 
Sent: Friday, February 11, 2022 11:53 AM
To: Nitin Rawat (QUIC) <quic_nitirawa@...cinc.com>
Cc: Keith Busch <kbusch@...nel.org>; Jens Axboe <axboe@...com>; Sagi Grimberg <sagi@...mberg.me>; linux-nvme@...ts.infradead.org; linux-kernel@...r.kernel.org; Sajida Bhanu (Temp) (QUIC) <quic_c_sbhanu@...cinc.com>
Subject: Re: [PATCH v3] nvme/pci: Add quick suspend quirk for Sc7280 Platform

On Fri, Feb 11, 2022 at 02:23:28AM +0530, Nitin Rawat wrote:
> Enable quick suspend quirks for Sc7280 platform, where power to nvme 
> device is removed during suspend-resume process. This is done to avoid 
> the failure dring resume.

You need to sort this out in the PCI and PM layers.  The broken platform will also affect all other PCIe drivers and not just nvme.