linux-kernel - Re: drivers/hid/hid-nintendo.c:403:29: error: 'JC_RUMBLE_ZERO_AMP_PKT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Feb 2022 17:07:46 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     kernel test robot <lkp@...el.com>
cc:     "Daniel J. Ogorchock" <djogorchock@...il.com>,
        kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: drivers/hid/hid-nintendo.c:403:29: error: 'JC_RUMBLE_ZERO_AMP_PKT_CNT'
 defined but not used

On Mon, 14 Feb 2022, kernel test robot wrote:

> Hi Daniel,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   b81b1829e7e39f6cebdf6e4d5484eacbceda8554
> commit: dad74e18f72a852ae40ad7b4246841a1b7e196b5 HID: nintendo: prevent needless queueing of the rumble worker
> date:   4 months ago
> config: parisc-randconfig-r024-20220213 (https://download.01.org/0day-ci/archive/20220214/202202140412.ltmfle7c-lkp@intel.com/config)
> compiler: hppa-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dad74e18f72a852ae40ad7b4246841a1b7e196b5
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout dad74e18f72a852ae40ad7b4246841a1b7e196b5
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=parisc SHELL=/bin/bash drivers/hid/ fs/notify/fanotify/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):

Daniel, I understand that the constants are there for future reference, 
but could you please submit a patch that'd make them commented out for 
now?

Thanks,

-- 
Jiri Kosina
SUSE Labs