linux-kernel - Re: [PATCH v4] hwmon: (asus-ec-sensors) merge setup functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e14486b-36c0-5869-a368-98b90b4dcd14@roeck-us.net>
Date:   Wed, 16 Feb 2022 11:13:15 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Eugene Shalygin <eugene.shalygin@...il.com>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] hwmon: (asus-ec-sensors) merge setup functions

On 2/16/22 11:00, Eugene Shalygin wrote:
> On Wed, 16 Feb 2022 at 19:49, Guenter Roeck <linux@...ck-us.net> wrote:
> 
>> * If your patch generates checkpatch errors, warnings, or check messages,
>>     please refrain from explanations such as "I prefer that coding style".
>>     Keep in mind that each unnecessary message helps hiding a real problem,
>>     and a consistent coding style makes it easier for others to understand
>>     and review the code.
> 
> Yes, of course. My question is what do I do with 6 other braces single
> statement if's now?
> 

Nothing as part of this patch. My fault for not bringing this up earlier,
but that is no reason to not clean up the code while touching it.

You _could_ submit a separate patch fixing everything reported by
checkpatch, but that is up to you.

Thanks,
Guenter