lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Feb 2022 20:38:18 +0100 From: Daniel Lezcano <daniel.lezcano@...aro.org> To: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>, rafael@...nel.org Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, Sasha Levin <sashal@...nel.org>, William Breathitt Gray <vilhelm.gray@...il.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com> Subject: Re: [RFC PATCH 1/4] tools/lib/thermal: Add a thermal library Hi Srinivas, thanks for the review On 16/02/2022 17:40, srinivas pandruvada wrote: > On Mon, 2022-02-14 at 22:04 +0100, Daniel Lezcano wrote: >> The thermal framework implements a netlink notification mechanism to >> be used by the userspace to have a thermal configuration discovery, >> trip point changes or violation, cooling device changes >> notifications, >> etc... >> >> This library provides a level of abstraction for the thermal netlink >> notification allowing the userspace to connect to the notification >> mechanism more easily. The library is callback oriented. >> > Some minor comments. > May be better use some defines instead of returning "-1" for error > conditions. Do you suggest like an enum with different errors or just having -1 replaced by eg. THERMAL_ERROR ? [ ... ] >> + * Low level netlink >> + */ >> +extern int nl_subscribe_thermal(struct nl_sock *nl_sock, struct >> nl_cb *nl_cb, >> + const char *group); >> + > To complete API, don't we need nl_unsubscribe which calls > nl_socket_drop_memberships()? Ah, yes. I'll add it. Thanks -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists