linux-kernel - Re: [PATCH v3] usb: gadget: f_uac1: add different speed transfers support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Feb 2022 10:24:27 +0800 (GMT+08:00)
From:   冷静 <3090101217@....edu.cn>
To:     "Greg KH" <gregkh@...uxfoundation.org>
Cc:     balbi@...nel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, pavel.hofman@...tera.com,
        ruslan.bilovol@...il.com, "Jing Leng" <jleng@...arella.com>
Subject: Re: [PATCH v3] usb: gadget: f_uac1: add different speed transfers
 support

Hi Greg KH,

Sorry for the trouble, as a new contributor to kernel.
Although I have readed the document that how to submit patches,
I'm still missing some details.

> Where is the patch version information?
The new patch adds more detailed patch description and adds
'static' before 'struct usb_ss_ep_comp_descriptor ac_int_ep_desc_comp'.

> Why are you setting values to 0 when you do not have to as that is the
> default value?
This modification is similar to uac2.
On page 362 of the USB3.2 specification.
bMaxBurst is 0 means that no burst transfer.
bmAttributes is 0 means that no mult.
So the "Maximum number of packets = (bMaxBurst + 1) x (Mult + 1)" is 1.

> The above change is not needed here.
Notice this modification style.

thanks,

Jing Leng