linux-kernel - Re: [PATCH] net: dsa: lan9303: add VLAN IDs to master device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220216195517.o6dk64gwoe4sizl6@skbuf>
Date:   Wed, 16 Feb 2022 21:55:17 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     Mans Rullgard <mans@...sr.com>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Juergen Borleis <kernel@...gutronix.de>,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        kbuild-all@...ts.01.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: dsa: lan9303: add VLAN IDs to master device

On Thu, Feb 17, 2022 at 03:33:39AM +0800, kernel test robot wrote:
> >> drivers/net/dsa/lan9303-core.c:1095:2: error: implicit declaration of function 'vlan_vid_add' [-Werror,-Wimplicit-function-declaration]
>            vlan_vid_add(cpu_dp->master, htons(ETH_P_8021Q), port);
>            ^
> >> drivers/net/dsa/lan9303-core.c:1111:2: error: implicit declaration of function 'vlan_vid_del' [-Werror,-Wimplicit-function-declaration]
>            vlan_vid_del(cpu_dp->master, htons(ETH_P_8021Q), port);
>            ^

#include <linux/if_vlan.h>

drivers/net/dsa/Kconfig:

config NET_DSA_SMSC_LAN9303
	depends on VLAN_8021Q || VLAN_8021Q=n

and maybe you can access using dp->cpu_dp in the next revision.