linux-kernel - Re: [PATCH v2] ARM: dts: sun8i: Adjust power key nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Feb 2022 20:26:14 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Jernej Škrabec <jernej.skrabec@...il.com>,
        mripard@...nel.org, wens@...e.org, robh+dt@...nel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Michael Klein <michael@...sekall.de>,
        Hans Verkuil <hverkuil-cisco@...all.nl>
Subject: Re: [PATCH v2] ARM: dts: sun8i: Adjust power key nodes

On Tue, Feb 15, 2022 at 10:11:36PM -0600, Samuel Holland wrote:
[ ... ]
> 
> I don't think there is any real issue here. The two irq_desc's being locked are
> always different, so there is no deadlock. This recursive irq_set_irq_wake seems
> to be a reasonably common pattern in GPIO drivers, and several of them contain
> code to silence lockdep. I've sent a patch adding a copy of that to the sunxi
> driver:
> 
> https://lore.kernel.org/lkml/20220216040037.22730-1-samuel@sholland.org/
> 
> Please see if it works for you.
> 
Yes, it does. The warning is gone with your patch applied on top of linux-next.

Thanks,
Guenter