linux-kernel - Re: [PATCH v3 1/4] Input: Extract ChromeOS vivaldi physmap show function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgyNScQJNVjJpqEc@google.com>
Date:   Tue, 15 Feb 2022 21:36:09 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     benjamin.tissoires@...hat.com, Jiri Kosina <jikos@...nel.org>,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        Sean O'Brien <seobrien@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        Zhengqiao Xia <xiazhengqiao@...qin.corp-partner.google.com>
Subject: Re: [PATCH v3 1/4] Input: Extract ChromeOS vivaldi physmap show
 function

On Thu, Feb 10, 2022 at 05:25:07PM -0800, Stephen Boyd wrote:
> Let's introduce a common library file for the physmap show function
> duplicated between three different keyboard drivers. This largely copies
> the code from cros_ec_keyb.c which has the most recent version of the
> show function, while using the vivaldi_data struct from the hid-vivaldi
> driver. This saves a small amount of space in an allyesconfig build.
> 
> $ ./scripts/bloat-o-meter vmlinux.before vmlinux.after
> 
> add/remove: 3/0 grow/shrink: 2/3 up/down: 412/-720 (-308)
> Function                                     old     new   delta
> vivaldi_function_row_physmap_show              -     292    +292
> _sub_I_65535_1                           1057564 1057616     +52
> _sub_D_65535_0                           1057564 1057616     +52
> e843419@...2_00062737_9b04                     -       8      +8
> e843419@...6_0002a34d_35bc                     -       8      +8
> atkbd_parse_fwnode_data                      480     472      -8
> atkbd_do_show_function_row_physmap           316      76    -240
> function_row_physmap_show                    620     148    -472
> Total: Before=285581925, After=285581617, chg -0.00%
> 
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: "Sean O'Brien" <seobrien@...omium.org>
> Cc: Douglas Anderson <dianders@...omium.org>
> Cc: Zhengqiao Xia <xiazhengqiao@...qin.corp-partner.google.com>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>  drivers/hid/Kconfig                   |  1 +
>  drivers/hid/hid-vivaldi.c             | 27 +++++--------------
>  drivers/input/Kconfig                 |  7 +++++
>  drivers/input/Makefile                |  1 +
>  drivers/input/keyboard/Kconfig        |  2 ++
>  drivers/input/keyboard/atkbd.c        | 22 +++++----------
>  drivers/input/keyboard/cros_ec_keyb.c | 32 ++++++++--------------
>  drivers/input/vivaldi-keymap.c        | 39 +++++++++++++++++++++++++++
>  include/linux/input/vivaldi-keymap.h  | 28 +++++++++++++++++++

Since you called the config INPUT_VIVALDIFMAP I think we should call
these files vivaldi-fmap.(h|c) as well. They are not really keymaps.

Anyway, this makes sense to me. Jiri, Benjamin, do you want to merge
this or do you want to take it all throgh your tree?

Thanks.

-- 
Dmitry