linux-kernel - Re: [PATCH v4] x86/cpu: clear SME feature flag when not in use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgzTCtlMq9+4IsZ4@zn.tnic>
Date:   Wed, 16 Feb 2022 11:33:46 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Thomas Lendacky <Thomas.Lendacky@....com>, hughsient@...il.com,
        Martin Fernandez <martin.fernandez@...ypsium.com>,
        linux-kernel@...r.kernel.org, Brijesh Singh <brijesh.singh@....com>
Subject: Re: [PATCH v4] x86/cpu: clear SME feature flag when not in use

On Tue, Feb 15, 2022 at 09:44:46PM -0600, Mario Limonciello wrote:
> @@ -607,6 +609,9 @@ static void early_detect_mem_encrypt(struct cpuinfo_x86 *c)
>  		if (IS_ENABLED(CONFIG_X86_32))
>  			goto clear_all;
>  
> +		if (!sme_me_mask)
> +			setup_clear_cpu_cap(X86_FEATURE_SME);

Why not "goto clear_all;" ?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette