linux-kernel - Re: [PATCH] printk: make suppress_panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72njcv_MYfTYycMqarEgN0ujKOSvT6OfQxW-kN6FDb5MRw@mail.gmail.com>
Date:   Wed, 16 Feb 2022 11:35:53 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        John Ogness <john.ogness@...utronix.de>,
        Kees Cook <keescook@...omium.org>, anton@...msg.org,
        ccross@...roid.com, Tony Luck <tony.luck@...el.com>,
        Miguel Ojeda <ojeda@...nel.org>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...gle.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        rust-for-linux <rust-for-linux@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] printk: make suppress_panic_printk static

On Wed, Feb 16, 2022 at 4:20 AM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> This symbol is not used outside of printk.c, so marks it static.
>
> Fix the following sparse warning:
>
> kernel/printk/printk.c:100:19: warning: symbol 'suppress_panic_printk'
> was not declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

It could be good to mention this is based on -next.

Reviewed-by: Miguel Ojeda <ojeda@...nel.org>

Cheers,
Miguel